Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for py3.7 #3291

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Drop support for py3.7 #3291

merged 4 commits into from
Jan 28, 2022

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Jan 28, 2022

Unblocks #3275 and #3290.

@jeremyliweishih
Copy link
Contributor Author

I think this PR might require @dsherry or @chukarsten to remove the 3.7 tests from required checks as well!

@@ -18,6 +18,7 @@
long_description=long_description,
long_description_content_type="text/markdown",
url='https://github.com/alteryx/evalml/',
python_requires='>=3.8, <4',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this? This is what pip looks at when determining if your python version would work with a library. Saw this in the WW repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #3291 (88f6d93) into main (23e2433) will decrease coverage by 26.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #3291      +/-   ##
========================================
- Coverage   99.8%   72.9%   -26.8%     
========================================
  Files        322     322              
  Lines      31600   31600              
========================================
- Hits       31510   23031    -8479     
- Misses        90    8569    +8479     
Impacted Files Coverage Δ
evalml/tests/component_tests/test_lda.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/component_tests/test_lsa.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/component_tests/test_pca.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/demo_tests/test_datasets.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/objective_tests/test_sla.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/test_all_test_dirs_included.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/component_tests/test_imputer.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/data_checks_tests/test_utils.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/component_tests/test_estimators.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/objective_tests/test_objectives.py 0.0% <0.0%> (-100.0%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e2433...88f6d93. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @jeremyliweishih ! We'll need @chukarsten to get this in with his magic powers hehe

@chukarsten chukarsten merged commit f73fa0f into main Jan 28, 2022
@chukarsten chukarsten deleted the js_drop_37 branch January 28, 2022 19:18
@chukarsten chukarsten mentioned this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants