-
Notifications
You must be signed in to change notification settings - Fork 91
Adding TimeSeriesFeaturizer to ARIMA #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3313 +/- ##
=======================================
+ Coverage 99.6% 99.6% +0.1%
=======================================
Files 329 329
Lines 32229 32229
=======================================
+ Hits 32099 32100 +1
+ Misses 130 129 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, very cool that there weren't too many lines that needed to be change and the performance clearly improves so much (at the expense of time)! Great job getting back to this and making it work for ARIMA @ParthivNaresh 😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Parthiv!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left one nit on the release notes
docs/source/release_notes.rst
Outdated
@@ -3,6 +3,7 @@ | |||
|
|||
**Future Releases** | |||
* Enhancements | |||
* Added `TimeSeriesFeaturizer` into ARIMA-based pipelines :pr:`3313` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double tic marks here around TimeSeriesFeaturizer
# Conflicts: # docs/source/release_notes.rst
Fixes: #2992 #2960
Performance tests: https://alteryx.atlassian.net/wiki/spaces/PS/pages/1226148272/ARIMA+performance+with+TimeSeriesFeaturizer