Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message code for no variance zero null #3372

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #3371


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #3372 (23d1c38) into main (e431eff) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3372     +/-   ##
=======================================
+ Coverage   99.6%   99.6%   +0.1%     
=======================================
  Files        329     329             
  Lines      32229   32230      +1     
=======================================
+ Hits       32100   32101      +1     
  Misses       129     129             
Impacted Files Coverage Δ
evalml/data_checks/no_variance_data_check.py 100.0% <ø> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <ø> (ø)
...s/data_checks_tests/test_no_variance_data_check.py 100.0% <ø> (ø)
evalml/data_checks/data_check_message_code.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e431eff...23d1c38. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@freddyaboulton freddyaboulton merged commit 3a424e6 into main Mar 15, 2022
@freddyaboulton freddyaboulton deleted the separate-codes-no-variance branch March 15, 2022 13:35
@chukarsten chukarsten mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use separate data check codes for one and zero unique values in NoVarianceDataCheck
2 participants