Skip to content

Checkout main branch in build-conda-pkg #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Mar 15, 2022

Pull Request Description

Github renamed the master branch of the feedstock to main so we need to update build_conda_pkg


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #3375 (ef8a42b) into main (3a424e6) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3375   +/-   ##
=====================================
  Coverage   99.6%   99.6%           
=====================================
  Files        329     329           
  Lines      32230   32230           
=====================================
  Hits       32101   32101           
  Misses       129     129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a424e6...ef8a42b. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review March 15, 2022 16:24
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

- 'requirements.txt'
- 'core-requirements.txt'
- 'evalml/tests/dependency_update_check/*.txt'
# paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

- 'requirements.txt'
- 'core-requirements.txt'
- 'evalml/tests/dependency_update_check/*.txt'
# paths:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s just so that I could trigger the job. Will revert prior to merge!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@freddyaboulton freddyaboulton merged commit 30c85e5 into main Mar 15, 2022
@freddyaboulton freddyaboulton deleted the fix-build-conda-pkg branch March 15, 2022 18:38
@chukarsten chukarsten mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants