Skip to content

Revert Pandas 1.3.0 Compatibility Patch#3378

Merged
fjlanasa merged 3 commits into
mainfrom
fl/OSSEVALML-135
Mar 17, 2022
Merged

Revert Pandas 1.3.0 Compatibility Patch#3378
fjlanasa merged 3 commits into
mainfrom
fl/OSSEVALML-135

Conversation

@fjlanasa

@fjlanasa fjlanasa commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

@gsheni gsheni changed the title OSSEVALML-135 Revert Pandas 1.3.0 Compatibility Patch Revert Pandas 1.3.0 Compatibility Patch Mar 15, 2022
@codecov

codecov Bot commented Mar 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3378 (f970c86) into main (d6af026) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #3378     +/-   ##
=======================================
- Coverage   99.6%   99.6%   -0.0%     
=======================================
  Files        329     329             
  Lines      32230   32227      -3     
=======================================
- Hits       32101   32098      -3     
  Misses       129     129             
Impacted Files Coverage Δ
...valml/pipelines/components/estimators/estimator.py 100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6af026...f970c86. Read the comment docs.

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjlanasa Looks good to me! I see the minimum xgboost version is 1.4.2 so there's little risk of someone using a version that still needs this patch.

@fjlanasa
fjlanasa merged commit 49d5444 into main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert Pandas 1.3.0 Compatibility Patch

2 participants