Small fix to make time series featurizer deterministic#3384
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3384 +/- ##
=======================================
+ Coverage 99.6% 99.6% +0.1%
=======================================
Files 329 329
Lines 32231 32241 +10
=======================================
+ Hits 32102 32112 +10
Misses 129 129
Continue to review full report at Codecov.
|
jeremyliweishih
approved these changes
Mar 16, 2022
Collaborator
jeremyliweishih
left a comment
There was a problem hiding this comment.
Left a comment but looks great!
evalml/pipelines/components/transformers/preprocessing/time_series_featurizer.py
Show resolved
Hide resolved
freddyaboulton
approved these changes
Mar 21, 2022
Contributor
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you @bchen1116 !!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this fix, we see this in the perf tests:

Ultimately, we note that the before and after scores for both of these pipelines are the same, so there could be an issue with how we're storing the full rankings or finding the order in LG. However, this PR is focused on making TS deterministic.
The full, fixed report is below:
report_ts.html.zip
The perf tests look good! Seems like the behavior is now the same between runs