exclude non-latest versions of docs from broken link checker#3401
Merged
exclude non-latest versions of docs from broken link checker#3401
Conversation
fjlanasa
force-pushed
the
fl/fix-link-checker
branch
2 times, most recently
from
6fca6a4 to
ccabf8a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3401 +/- ##
=====================================
Coverage 99.6% 99.6%
=====================================
Files 329 329
Lines 32380 32380
=====================================
Hits 32249 32249
Misses 131 131 Continue to review full report at Codecov.
|
fjlanasa
force-pushed
the
fl/fix-link-checker
branch
from
ccabf8a to
3f6eaca
Compare
freddyaboulton
approved these changes
Mar 24, 2022
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you for the fix @fjlanasa !
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Follow up to #3398
The crawler ended up following a link on the latest version of the docs to the stable version of the docs, which did not contain a fix to a broken link, leading to a failed check. This PR updates the
excludeargument to not check documentation pages for versions other than latest.After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.