Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor partial dependence functions #3404

Merged
merged 14 commits into from
Mar 28, 2022
Merged

Refactor partial dependence functions #3404

merged 14 commits into from
Mar 28, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Mar 24, 2022

Moves all partial dependence functions to two files: a private file for all the implementation and utility functions and a public file for the API. Part of the work to refactor graph.py for ease of use.

This PR looks big but none of the code is actually different, just in different places.

@eccabay eccabay changed the title 3521 part dep Refactor partial dependence functions Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #3404 (4797511) into main (b8b4941) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3404     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        329     330      +1     
  Lines      32406   32424     +18     
=======================================
+ Hits       32277   32295     +18     
  Misses       129     129             
Impacted Files Coverage Δ
...lml/tests/model_understanding_tests/test_graphs.py 100.0% <ø> (ø)
evalml/model_understanding/__init__.py 100.0% <100.0%> (ø)
...l/model_understanding/_partial_dependence_utils.py 99.3% <100.0%> (ø)
evalml/model_understanding/graphs.py 100.0% <100.0%> (ø)
...odel_understanding/partial_dependence_functions.py 100.0% <100.0%> (ø)
...del_understanding_tests/test_partial_dependence.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b4941...4797511. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, as always, for taking the initiative.

@eccabay eccabay merged commit 06cd148 into main Mar 28, 2022
@chukarsten chukarsten mentioned this pull request Mar 28, 2022
@eccabay eccabay deleted the 3521_part_dep branch April 19, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants