-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor partial dependence functions #3404
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3404 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 329 330 +1
Lines 32406 32424 +18
=======================================
+ Hits 32277 32295 +18
Misses 129 129
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, as always, for taking the initiative.
Moves all partial dependence functions to two files: a private file for all the implementation and utility functions and a public file for the API. Part of the work to refactor
graph.py
for ease of use.This PR looks big but none of the code is actually different, just in different places.