Conversation
Codecov Report
@@ Coverage Diff @@
## main #3404 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 329 330 +1
Lines 32406 32424 +18
=======================================
+ Hits 32277 32295 +18
Misses 129 129
Continue to review full report at Codecov.
|
chukarsten
approved these changes
Mar 28, 2022
Contributor
chukarsten
left a comment
There was a problem hiding this comment.
LGTM! Thank you, as always, for taking the initiative.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all partial dependence functions to two files: a private file for all the implementation and utility functions and a public file for the API. Part of the work to refactor
graph.pyfor ease of use.This PR looks big but none of the code is actually different, just in different places.