Skip to content

Fix feature provenance for URL and Email features in DefaultAlgorithm#3419

Merged
jeremyliweishih merged 15 commits into
mainfrom
js_3392_email_default
Apr 1, 2022
Merged

Fix feature provenance for URL and Email features in DefaultAlgorithm#3419
jeremyliweishih merged 15 commits into
mainfrom
js_3392_email_default

Conversation

@jeremyliweishih

Copy link
Copy Markdown
Collaborator

Fixes #3392.

@codecov

codecov Bot commented Mar 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3419 (0257830) into main (e824043) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3419     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        332     332             
  Lines      32548   32576     +28     
=======================================
+ Hits       32418   32446     +28     
  Misses       130     130             
Impacted Files Coverage Δ
...valml/automl/automl_algorithm/default_algorithm.py 100.0% <100.0%> (ø)
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e824043...0257830. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review March 30, 2022 20:34

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeremyliweishih !

Comment thread evalml/automl/automl_algorithm/default_algorithm.py Outdated
Comment thread evalml/automl/automl_algorithm/default_algorithm.py
Comment thread evalml/automl/automl_algorithm/default_algorithm.py Outdated
@freddyaboulton

Copy link
Copy Markdown
Contributor

@jeremyliweishih Also, let's make sure Restaurant Likes is in our perf test dataset collection!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Algorithm errors out on dataset with email/url features

2 participants