Skip to content

Retrieve logical types passed to a component in the graph #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #3418


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #3428 (42a9190) into main (9282cc6) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3428     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        332     332             
  Lines      32510   32545     +35     
=======================================
+ Hits       32380   32415     +35     
  Misses       130     130             
Impacted Files Coverage Δ
evalml/pipelines/component_graph.py 99.8% <100.0%> (+0.1%) ⬆️
...valml/tests/pipeline_tests/test_component_graph.py 99.9% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9282cc6...42a9190. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the save-estimator-logical-types branch from 2e9c896 to 578362c Compare March 30, 2022 21:33
@freddyaboulton freddyaboulton marked this pull request as ready for review March 31, 2022 13:49
@freddyaboulton freddyaboulton force-pushed the save-estimator-logical-types branch from 0c6fac5 to 42a9190 Compare March 31, 2022 14:22
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Send it.

Dict - Mapping feature name to logical type instance.

Raises:
ValueError: If the component is not in the graph.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hypernit - I'm not sure what the convention is if a function itself does not directly raise an exception. I feel like we can probably remove the Raises from here. If you take it to a logical extreme, you could include tons of nested exceptions if you don't limit it to just the immediate scope of the function. Feel free to just merge though, this is not a hill I will die on...or will I?

@freddyaboulton freddyaboulton merged commit 5e7029f into main Mar 31, 2022
@freddyaboulton freddyaboulton deleted the save-estimator-logical-types branch March 31, 2022 15:37
@chukarsten chukarsten mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store/Retrieve Logical Types passed to the pipeline estimator
3 participants