Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename graphs.py to visualizations.py #3439

Merged
merged 6 commits into from
Apr 4, 2022
Merged

Rename graphs.py to visualizations.py #3439

merged 6 commits into from
Apr 4, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Apr 1, 2022

Final step of the code side of the graphs.py overhaul (docs updates coming next). graphs.py has been renamed, and now only contains functions that are visualization-specific model understanding functions.

Happy to move more functions around if parts of this organization don't make sense.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #3439 (47f41f4) into main (40b7e34) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3439     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        334     334             
  Lines      32951   32959      +8     
=======================================
+ Hits       32821   32829      +8     
  Misses       130     130             
Impacted Files Coverage Δ
evalml/model_understanding/visualizations.py 100.0% <ø> (ø)
evalml/model_understanding/__init__.py 100.0% <100.0%> (ø)
...odel_understanding/partial_dependence_functions.py 100.0% <100.0%> (ø)
...alml/model_understanding/permutation_importance.py 100.0% <100.0%> (ø)
...understanding_tests/test_permutation_importance.py 100.0% <100.0%> (ø)
...s/model_understanding_tests/test_visualizations.py 100.0% <100.0%> (ø)
evalml/tests/utils_tests/test_gen_utils.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7e34...47f41f4. Read the comment docs.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for completing this!

@eccabay eccabay enabled auto-merge (squash) April 4, 2022 18:59
@eccabay eccabay merged commit df13ed9 into main Apr 4, 2022
@eccabay eccabay deleted the 3523_graphs_to_viz branch April 4, 2022 19:39
@chukarsten chukarsten mentioned this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants