Increase coverage of model understanding functions in docs#3446
Increase coverage of model understanding functions in docs#3446
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3446 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 336 336
Lines 33297 33297
=====================================
Hits 33165 33165
Misses 132 132 Continue to review full report at Codecov.
|
eccabay
requested review from
bchen1116,
christopherbunn,
chukarsten,
fjlanasa,
freddyaboulton and
jeremyliweishih
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you @eccabay !
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
I really love this, thank you.
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Great work adding these in! There is a graphing issue that I think blocks this, but left some nits as well!
| " })\n", | ||
| "pipeline_linear.fit(X_train, y_train)\n", | ||
| "\n", | ||
| "get_linear_coefficients(pipeline_linear.estimator, features=X.columns)" |
There was a problem hiding this comment.
nit: Not sure if this would be good as a change to the function output or just a small change to the cell, but I think it'd look cleaner and make more sense for OS users if we showed this as a dataframe with column names labeled:
Similar to
| "source": [ | ||
| "from evalml.model_understanding import graph_t_sne\n", | ||
| "\n", | ||
| "graph_t_sne(X)" |
There was a problem hiding this comment.
There's no output here:
Filed an issue here but likely need to address that first before we can move in with this.
There was a problem hiding this comment.
So weird and good catch @bchen1116 ! Maybe we can try to build the docs locally to see if they show up in the generated html
There was a problem hiding this comment.
@bchen1116 since this graphing issue is independent of these changes, not sure it's worth it to block this PR on them getting fixed
4 participants
We were missing descriptions of a few functions, this adds those.