Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of model understanding plotly charts in docs #3460

Merged
merged 14 commits into from
May 2, 2022

Conversation

christopherbunn
Copy link
Contributor

Resolves #3447

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #3460 (b27589f) into main (0873b5c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3460   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        336     336           
  Lines      33400   33400           
=====================================
  Hits       33274   33274           
  Misses       126     126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0873b5c...b27589f. Read the comment docs.

@christopherbunn christopherbunn changed the title Fix rendering of plotly graphs in docs Fix rendering of model understanding plotly charts in docs Apr 20, 2022
@christopherbunn
Copy link
Contributor Author

It looks like all of the plots except for the search iteration plots are now showing.

Example:

I think the search iteration plot is going to take a bit more work. Basically, I think it comes down to the fact that we're dynamically building and updating this figure over multiple iterations, whereas these plots above are only shown after they're finished. I can file a separate ticket for the search iteration plot.

@christopherbunn christopherbunn marked this pull request as ready for review May 2, 2022 15:13
@christopherbunn christopherbunn requested a review from a team May 2, 2022 15:13
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @christopherbunn !

@christopherbunn christopherbunn merged commit 14db5ff into main May 2, 2022
@christopherbunn
Copy link
Contributor Author

It looks like we already have an issue specific to the AutoML search iteration plots here: #1692. We'll use this to track additional work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphs not appearing in documentation
2 participants