Change PipelineBase.graph_json() to return python dictionary
#3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3463 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 336 336
Lines 33375 33368 -7
=======================================
- Hits 33243 33236 -7
Misses 132 132
Continue to review full report at Codecov.
|
jeremyliweishih
requested review from
eccabay,
freddyaboulton,
christopherbunn,
fjlanasa and
chukarsten
freddyaboulton
approved these changes
Apr 13, 2022
eccabay
approved these changes
Apr 14, 2022
evalml/pipelines/pipeline_base.py
Outdated
| @@ -440,7 +439,7 @@ def graph_json(self): | |||
| "y_edges": [[from_component_name, to_component_name], [from_component_name, to_component_name], ...]} | |||
|
|
|||
| Returns: | |||
| dag_json (str): A serialized JSON representation of a DAG structure. | |||
| dag_dict (dict): A dictionary of the DAG structure. | |||
There was a problem hiding this comment.
Nit: "A dictionary of the DAG structure" -> "A dictionary representing the DAG structure"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3073. Will file another issue to keep track of refactoring for
graphandgraph_dict.