Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROC Curve Refactor for Nullable Types #3465

Merged
merged 16 commits into from
Apr 29, 2022
Merged

Conversation

chukarsten
Copy link
Contributor

@chukarsten chukarsten commented Apr 15, 2022

Fixes #3471

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #3465 (c60164f) into main (882a9e4) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3465     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        336     336             
  Lines      33364   33400     +36     
=======================================
+ Hits       33238   33274     +36     
  Misses       126     126             
Impacted Files Coverage Δ
evalml/model_understanding/metrics.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 97.5% <100.0%> (+0.1%) ⬆️
...ml/tests/model_understanding_tests/test_metrics.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882a9e4...c60164f. Read the comment docs.

@chukarsten chukarsten marked this pull request as ready for review April 19, 2022 16:16
@chukarsten chukarsten changed the title Draft: Rebased ROC Curve Refactor for Nullable Types ROC Curve Refactor for Nullable Types Apr 19, 2022
@chukarsten chukarsten marked this pull request as draft April 21, 2022 15:43
@chukarsten chukarsten marked this pull request as ready for review April 27, 2022 17:55
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful work 🤌

@chukarsten chukarsten enabled auto-merge (squash) April 29, 2022 18:16
@chukarsten chukarsten merged commit af693ce into main Apr 29, 2022
@chukarsten chukarsten mentioned this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROC Curve Adjustments for Nullable Types
2 participants