Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeSeriesRegularizer and TimeSeriesImputer to the user guide #3473

Merged
merged 6 commits into from
Apr 27, 2022
Merged

Add TimeSeriesRegularizer and TimeSeriesImputer to the user guide #3473

merged 6 commits into from
Apr 27, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Apr 21, 2022

Closes #3422

@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #3473 (c1023f4) into main (b0e0946) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3473   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        336     336           
  Lines      33364   33364           
=====================================
  Hits       33238   33238           
  Misses       126     126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e0946...c1023f4. Read the comment docs.

@eccabay eccabay marked this pull request as ready for review April 21, 2022 15:58
freddyaboulton
freddyaboulton approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @eccabay ! Just left some minor nits.

docs/source/user_guide/timeseries.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/timeseries.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/timeseries.ipynb Outdated Show resolved Hide resolved
ParthivNaresh
ParthivNaresh approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just left a couple of nits!

docs/source/user_guide/timeseries.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/timeseries.ipynb Outdated Show resolved Hide resolved
@eccabay eccabay merged commit 721d27a into main Apr 27, 2022
@eccabay eccabay deleted the 3422_ts_documentation branch April 27, 2022 15:46
@chukarsten chukarsten mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

@christopherbunn christopherbunn Awaiting requested review from christopherbunn

@chukarsten chukarsten Awaiting requested review from chukarsten

@fjlanasa fjlanasa Awaiting requested review from fjlanasa

Assignees

@eccabay eccabay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation to include TimeSeriesRegularizer and Imputer
3 participants
@eccabay @ParthivNaresh @freddyaboulton