Skip to content

Conversation

@fjlanasa
Copy link
Contributor

Pull Request Description

(replace this text with your description)


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3481 (73e4ad1) into main (9ba3751) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #3481   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        336     336           
  Lines      33364   33364           
=====================================
  Hits       33238   33238           
  Misses       126     126           
Impacted Files Coverage Δ
...nent_tests/test_vowpal_wabbit_binary_classifier.py 100.0% <100.0%> (ø)
..._tests/test_vowpal_wabbit_multiclass_classifier.py 100.0% <100.0%> (ø)
...ts/component_tests/test_vowpal_wabbit_regressor.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba3751...73e4ad1. Read the comment docs.

@fjlanasa fjlanasa requested a review from freddyaboulton April 26, 2022 15:26
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @fjlanasa !

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! Angela would be proud.

@chukarsten chukarsten merged commit ccec34c into main Apr 27, 2022
@chukarsten chukarsten deleted the fl/add-vowpal branch April 27, 2022 23:16
@chukarsten chukarsten mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants