Fix some unit tests after vowpal wabbit got added to conda #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
commented
Apr 28, 2022
| @@ -10,6 +10,7 @@ on: | |||
| - 'requirements.txt' | |||
| - 'core-requirements.txt' | |||
| - 'evalml/tests/dependency_update_check/*.txt' | |||
| - '.github/meta.yaml' | |||
There was a problem hiding this comment.
So that it runs when we update the recipe but not the requirement files.
Codecov Report
@@ Coverage Diff @@
## main #3486 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 336 336
Lines 33364 33364
=====================================
Hits 33238 33238
Misses 126 126
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
eccabay,
bchen1116,
jeremyliweishih,
christopherbunn,
chukarsten and
fjlanasa
jeremyliweishih
approved these changes
Apr 28, 2022
| @@ -9,7 +9,7 @@ source: | |||
| sha256: acb758f2234a60dd606a4aa7dcde385e159c95a08470b0c5815d085db48aa985 | |||
|
|
|||
| build: | |||
| number: 1 | |||
| number: 2 | |||
There was a problem hiding this comment.
why is this changing?
There was a problem hiding this comment.
Just so that I could run build_conda_pkg. In the real recipe it will start at 0.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The build_conda_pkg job doesn't run when you change the meta.yaml so we didn't catch some very minor unit test failures once we merged to main:
https://github.com/alteryx/evalml/runs/6202590714?check_suite_focus=true
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.