-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to pyproject.toml and setup.cfg #3494
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3494 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 336 335 -1
Lines 33415 33263 -152
=======================================
- Hits 33292 33135 -157
- Misses 123 128 +5
Continue to review full report at Codecov.
|
@eccabay Glad to see this happen for EvalML. You can delete MANIFEST.in and move it to setup.cfg
|
multi_line_output=3 | ||
skip=__init__.py | ||
|
||
[darglint] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be moved to pyproject.toml
@eccabay I think we also need to update |
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -585,10 +585,6 @@ def __init__( | |||
self.random_seed = random_seed | |||
self.n_jobs = n_jobs | |||
|
|||
if not self.plot and self.verbose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plotly moved from being a core-requirement to one of the regular requirements. self.plot
is only None if plotly isn't installed. Since we no longer test this case, I removed this to make codecov happy (and users that pip install us shouldn't have an issue regardless)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @eccabay !
Closes #3412
Also removes the concept of core-requirements within evalml. The core-requirements file still exists should users want to download evalml without catboost and xgboost, but there are no more tests or integrations for it. Ideally we'll remove this entirely in the future.