Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise custom exception for pipeline errors #3497

Merged
merged 5 commits into from
May 4, 2022
Merged

raise custom exception for pipeline errors #3497

merged 5 commits into from
May 4, 2022

Conversation

fjlanasa
Copy link
Contributor

@fjlanasa fjlanasa commented May 3, 2022

Pull Request Description

Adds new exception class PipelineError to be raised for errors encountered when applying pipelines. The first implementation will be for raising an error in _transform_features when input data types are different from the input types the pipeline was fitted on.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #3497 (d509b9e) into main (483ed9a) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3497     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        336     336             
  Lines      33400   33420     +20     
=======================================
+ Hits       33274   33294     +20     
  Misses       126     126             
Impacted Files Coverage Δ
evalml/exceptions/__init__.py 100.0% <ø> (ø)
evalml/exceptions/exceptions.py 100.0% <100.0%> (ø)
evalml/pipelines/component_graph.py 99.8% <100.0%> (ø)
...valml/tests/pipeline_tests/test_component_graph.py 99.9% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483ed9a...d509b9e. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fjlanasa !

docs/source/release_notes.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit about docstrings, but looks good, thank you!

evalml/exceptions/exceptions.py Show resolved Hide resolved
@fjlanasa fjlanasa merged commit f70e18e into main May 4, 2022
@chukarsten chukarsten mentioned this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants