Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to ignore emacs buffers #350

Merged
merged 2 commits into from Feb 12, 2020
Merged

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Feb 12, 2020

Am I the only emacs user on the team right now? :)


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request by adding :pr:123.

@dsherry dsherry added enhancement An improvement to an existing feature. task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. labels Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          96       96           
  Lines        2974     2974           
=======================================
  Hits         2889     2889           
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6451201...85253e4. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

:shipit: I think most of us us VScode haha

@dsherry dsherry merged commit 12ae1fd into master Feb 12, 2020
@dsherry dsherry deleted the ds_gitignore_emacs branch Feb 12, 2020
@dsherry
Copy link
Collaborator Author

dsherry commented Feb 12, 2020

@jeremyliweishih lol cool, good to know. I have no dogma about editors! But I don't wanna add emacs buffers to the repo by accident 😂

@dsherry dsherry self-assigned this Feb 12, 2020
@angela97lin angela97lin mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature. task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants