Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vowpal wabbit to evalml instead of evalml-core #3502

Merged
merged 4 commits into from
May 10, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

So that we can fix the broken test in conda-forge/evalml-core-feedstock#108. We'll get it in for the next release.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #3502 (b4f9806) into main (7ab846d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3502   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        336     336           
  Lines      33420   33420           
=====================================
  Hits       33294   33294           
  Misses       126     126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab846d...b4f9806. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review May 5, 2022 16:21
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chukarsten chukarsten enabled auto-merge (squash) May 10, 2022 17:25
@chukarsten chukarsten merged commit 2caa985 into main May 10, 2022
@chukarsten chukarsten mentioned this pull request May 12, 2022
@freddyaboulton freddyaboulton deleted the move-vpw-from-evalmlcore-to-evalml branch May 13, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants