Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows for Featuretools & Woodwork main #3504

Merged
merged 11 commits into from
May 11, 2022
Merged

Conversation

chukarsten
Copy link
Contributor

@chukarsten chukarsten commented May 8, 2022

Fixes: #3478, #3479

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #3504 (6252a8c) into main (ce9829f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3504   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        336     336           
  Lines      33417   33417           
=====================================
  Hits       33294   33294           
  Misses       123     123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9829f...6252a8c. Read the comment docs.

@chukarsten chukarsten changed the title First crack at feature tools workflow. Workflows for Featuretools & Woodwork main May 8, 2022
@chukarsten chukarsten requested a review from gsheni May 8, 2022 17:45
@chukarsten chukarsten marked this pull request as ready for review May 8, 2022 17:45
@chukarsten
Copy link
Contributor Author

Was this what you were looking for @gsheni ?

"url": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to setup a Slack webhook

@chukarsten chukarsten enabled auto-merge (squash) May 11, 2022 17:41
@chukarsten chukarsten merged commit ce783d3 into main May 11, 2022
@gsheni gsheni deleted the cross_lib_workflows branch May 11, 2022 20:15
@@ -0,0 +1,54 @@
name: Unit Tests - EvalML with Featuretools main branch
on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late to this PR! Awesome job @chukarsten and thanks for reviewing @gsheni !

Don't we need to add a workflow to woodwork and featuretools to kick off this job on commits to main?

Similar to this: https://github.com/alteryx/woodwork/blob/main/.github/workflows/kickoff_featuretools_unit_tests.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-version: ${{ matrix.python_version }}
- name: Checkout repository
uses: actions/checkout@v2
- name: Set up pip and graphviz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chukarsten I think we forgot the make package_evalml step here

@chukarsten chukarsten mentioned this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI workflow to run unit tests with latest from Woodwork main
3 participants