-
Notifications
You must be signed in to change notification settings - Fork 92
Workflows for Featuretools & Woodwork main #3504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3504 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 336 336
Lines 33417 33417
=====================================
Hits 33294 33294
Misses 123 123 Continue to review full report at Codecov.
|
|
Was this what you were looking for @gsheni ? |
| "url": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" | ||
| } | ||
| env: | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to setup a Slack webhook
- https://github.com/slackapi/slack-github-action#setup
I added you as a collab on the Featuretools one so you can see what it looks like
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
| @@ -0,0 +1,54 @@ | |||
| name: Unit Tests - EvalML with Featuretools main branch | |||
| on: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm late to this PR! Awesome job @chukarsten and thanks for reviewing @gsheni !
Don't we need to add a workflow to woodwork and featuretools to kick off this job on commits to main?
Similar to this: https://github.com/alteryx/woodwork/blob/main/.github/workflows/kickoff_featuretools_unit_tests.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added:
alteryx/featuretools#2072
| python-version: ${{ matrix.python_version }} | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
| - name: Set up pip and graphviz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chukarsten I think we forgot the make package_evalml step here
Fixes: #3478, #3479