Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3505 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 336 336
Lines 33436 33431 -5
=======================================
- Hits 33310 33308 -2
+ Misses 126 123 -3
Continue to review full report at Codecov.
|
chukarsten
requested review from
ParthivNaresh,
bchen1116,
christopherbunn,
eccabay,
fjlanasa,
freddyaboulton and
jeremyliweishih
and removed request for
eccabay and
freddyaboulton
chukarsten
commented
May 10, 2022
| assert len((_all_estimators_used_in_search())) == 9 | ||
| else: | ||
| if is_using_conda: | ||
| n_estimators = 16 |
Contributor
Author
There was a problem hiding this comment.
Was talking to @jeremyliweishih about this one. Apparently this line isn't covered in the global checks, but my fiddling with it caused the patch diff to fail.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2237