Updated NoVarianceDataCheck to return only Warnings#3506
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3506 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 336 336
Lines 33420 33420
=====================================
Hits 33294 33294
Misses 126 126
Continue to review full report at Codecov.
|
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# let's copy the datetime at row 1 for future use\n", |
There was a problem hiding this comment.
DateTimeFormatDataCheck isn't run for a binary problem type so all datetime error references are obsolete
| "results_no_errors = search_iterative(X_train_no_errors, y_train_no_errors, problem_type='binary')\n", | ||
| "results_no_errors" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
After these changes, the only error left is that the target has null. That leaves little reason to keep this in, but I think a separate issue should be filed to create a more robust example using more data checks with errors.
There was a problem hiding this comment.
Sure, please feel free to file and complete!
ParthivNaresh
requested review from
Cmancuso,
bchen1116,
chukarsten,
freddyaboulton and
jeff-hernandez
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
I think once I understand why we're doing this, this looks good to go.
| "results_no_errors = search_iterative(X_train_no_errors, y_train_no_errors, problem_type='binary')\n", | ||
| "results_no_errors" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Sure, please feel free to file and complete!
2 participants
No description provided.