Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update featuretools main workflow #3517

Merged
merged 18 commits into from
May 13, 2022
Merged

Update featuretools main workflow #3517

merged 18 commits into from
May 13, 2022

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented May 12, 2022

PR to iron out issues with the featuretools main CI workflow

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3517 (3eabe3b) into main (f63f62e) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3517     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        336     336             
  Lines      33417   33415      -2     
=======================================
- Hits       33294   33292      -2     
  Misses       123     123             
Impacted Files Coverage Δ
evalml/tests/component_tests/test_estimators.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63f62e...3eabe3b. Read the comment docs.

@freddyaboulton
Copy link
Contributor

Thank you for helping us fix @rwedge !!

WARNING: evalml 0.51.0 does not provide the extra 'test'

Since we're midway through switching to setup.cfg we can holdoff on this workflow? That way we don't add something to setup.py so that it's immediately deleted.

Thoughts @alteryx/evalml ?

@rwedge
Copy link
Contributor Author

rwedge commented May 12, 2022

@freddyaboulton perhaps could we use make commands to make the install commands less dependent on setup.py / setup.cfg configuration

@freddyaboulton
Copy link
Contributor

That's a great idea @rwedge ! I wonder if we can use the existing make installdeps-test command or if we need to add a new one to install from the same package. Both sound equivalent to me.

@freddyaboulton freddyaboulton marked this pull request as ready for review May 13, 2022 19:10
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

- name: Install EvalML & Featuretools - test requirements
run: |
python -m pip install -e unpacked_sdist/[test]
cd unpacked_sdist
make -f ../Makefile installdeps-prophet
Copy link
Contributor

@gsheni gsheni May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point in running make package_evalml if you are just going to run installdeps which just installs from the requirement text files.

@freddyaboulton freddyaboulton enabled auto-merge (squash) May 13, 2022 21:32
@freddyaboulton freddyaboulton merged commit 29d92a0 into main May 13, 2022
@freddyaboulton freddyaboulton deleted the rw-ft-main-workflow branch May 13, 2022 21:53
@freddyaboulton freddyaboulton mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants