Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack and stackoverflow icon to footer in docs #3528

Merged
merged 14 commits into from
May 24, 2022
Merged

Add slack and stackoverflow icon to footer in docs #3528

merged 14 commits into from
May 24, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 20, 2022

No description provided.

@gsheni gsheni changed the title Update layout.html Add slack and stackoverflow icon to footer in docs May 20, 2022
@gsheni gsheni self-assigned this May 20, 2022
@gsheni gsheni marked this pull request as ready for review May 20, 2022 15:16
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #3528 (ae787aa) into main (6b4e077) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3528   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        336     336           
  Lines      33415   33415           
=====================================
  Hits       33292   33292           
  Misses       123     123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4e077...ae787aa. Read the comment docs.

@gsheni gsheni requested review from eccabay and chukarsten May 23, 2022 13:49
@freddyaboulton
Copy link
Contributor

For some reason the change is not displaying in RTD

image

@gsheni
Copy link
Contributor Author

gsheni commented May 23, 2022

@freddyaboulton I am fairly certain this will work. Both Featuretools and Woodwork use this same exact code and it renders properly in the footer:

@freddyaboulton
Copy link
Contributor

Looks good except that the stack overflow icon does not render:

image

docs/source/_templates/layout.html Outdated Show resolved Hide resolved
docs/source/_templates/layout.html Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
@gsheni
Copy link
Contributor Author

gsheni commented May 24, 2022

@freddyaboulton solved:
d1a2cbe

@gsheni gsheni closed this May 24, 2022
@gsheni gsheni reopened this May 24, 2022
@gsheni
Copy link
Contributor Author

gsheni commented May 24, 2022

Screen Shot 2022-05-24 at 1 25 07 PM

Works now

@gsheni gsheni enabled auto-merge (squash) May 24, 2022 17:25
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsheni !

@gsheni gsheni merged commit 04f1388 into main May 24, 2022
@gsheni gsheni deleted the update_footer branch May 24, 2022 19:50
@freddyaboulton freddyaboulton mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants