Surpress warnings in target encoder #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
commented
Jun 3, 2022
| @@ -65,9 +67,14 @@ def __init__( | |||
| "category_encoders", | |||
| error_msg="category_encoders not installed. Please install using `pip install category_encoders`", | |||
| ) | |||
| # Supress warnings for now due to problems discussion here: | |||
| # https://github.com/scikit-learn-contrib/category_encoders/issues/327 | |||
| with warnings.catch_warnings(): | |||
There was a problem hiding this comment.
We could also change the default value of smoothing and add min_samples_leaf parameter but there is still some discussion as to what the new defaults should be so figured it was better to suppress the warnings
Codecov Report
@@ Coverage Diff @@
## main #3540 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 335 335
Lines 33263 33267 +4
=======================================
+ Hits 33135 33139 +4
Misses 128 128
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
eccabay,
jeremyliweishih,
christopherbunn,
chukarsten,
fjlanasa and
stefaniesmith
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix nightlies. Surpress warnings in target encoder due to scikit-learn-contrib/category_encoders#327
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.