Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noncore-dependency-marker #3541

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Remove the noncore_dependency pytest marker since it's no longer used


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #3541 (6347773) into main (7dbc2ab) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3541     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        335     335             
  Lines      33267   33176     -91     
=======================================
- Hits       33139   33048     -91     
  Misses       128     128             
Impacted Files Coverage Δ
evalml/tests/automl_tests/test_automl.py 99.5% <ø> (-<0.1%) ⬇️
.../automl_tests/test_automl_search_classification.py 96.4% <ø> (-<0.1%) ⬇️
...ests/automl_tests/test_automl_search_regression.py 95.1% <ø> (-<0.1%) ⬇️
evalml/tests/automl_tests/test_automl_utils.py 100.0% <ø> (ø)
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <ø> (ø)
...l/tests/automl_tests/test_pipeline_search_plots.py 100.0% <ø> (ø)
...alml/tests/component_tests/test_arima_regressor.py 100.0% <ø> (ø)
.../tests/component_tests/test_catboost_classifier.py 100.0% <ø> (ø)
...l/tests/component_tests/test_catboost_regressor.py 100.0% <ø> (ø)
...nent_tests/test_exponential_smoothing_regressor.py 100.0% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbc2ab...6347773. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@freddyaboulton freddyaboulton merged commit ee9d333 into main Jun 6, 2022
@freddyaboulton freddyaboulton deleted the remove-noncore-dependency-marker branch June 6, 2022 13:57
@freddyaboulton freddyaboulton mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants