Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install instructions for M1 mac install #3543

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #3500


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #3543 (1313ce7) into main (603290a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3543   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        335     335           
  Lines      33238   33238           
=====================================
  Hits       33109   33109           
  Misses       129     129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603290a...1313ce7. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some nits, thank you!

@@ -29,13 +29,28 @@ $ conda install -c conda-forge evalml
```
````

````{tab} PyPI (M1 Mac)
```console
# See the EvalML with core dependencies only section
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so since this is a code block


````{tab} Conda (M1 Mac)
```console
# See the EvalML with core dependencies only section
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

fail. The core set of EvalML dependencies can be installed in the M1 chip, so we recommend you install EvalML with core
dependencies.

Alternatively, we have heard from users that you can install all of EvalML's dependencies on the M1 chip using a Rosetta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: instead of "we have heard from users that you can" maybe something along the lines of "Alternatively, there is experimental support for M1 chips using a Rosetta terminal...". Sounds better IMO but up to your discretion!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - will make this change!

@freddyaboulton freddyaboulton changed the title Add tab for M1 mac install Add install instructions for M1 mac install Jun 7, 2022
@freddyaboulton freddyaboulton force-pushed the 3500-m1-install-instructions branch from be9c7a4 to 1313ce7 Compare June 7, 2022 20:34
@freddyaboulton freddyaboulton merged commit 7a4d17d into main Jun 8, 2022
@freddyaboulton freddyaboulton deleted the 3500-m1-install-instructions branch June 8, 2022 14:21
@freddyaboulton freddyaboulton mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install EvalML on M1 Mac - additional info needed in install instructions
2 participants