-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install instructions for M1 mac install #3543
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3543 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 335 335
Lines 33238 33238
=====================================
Hits 33109 33109
Misses 129 129 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some nits, thank you!
@@ -29,13 +29,28 @@ $ conda install -c conda-forge evalml | |||
``` | |||
```` | |||
|
|||
````{tab} PyPI (M1 Mac) | |||
```console | |||
# See the EvalML with core dependencies only section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so since this is a code block
|
||
````{tab} Conda (M1 Mac) | ||
```console | ||
# See the EvalML with core dependencies only section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise
docs/source/install.md
Outdated
fail. The core set of EvalML dependencies can be installed in the M1 chip, so we recommend you install EvalML with core | ||
dependencies. | ||
|
||
Alternatively, we have heard from users that you can install all of EvalML's dependencies on the M1 chip using a Rosetta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: instead of "we have heard from users that you can" maybe something along the lines of "Alternatively, there is experimental support for M1 chips using a Rosetta terminal...". Sounds better IMO but up to your discretion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - will make this change!
be9c7a4
to
1313ce7
Compare
Pull Request Description
Fixes #3500
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.