Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin nlp_primitives but disallow v2.6.0 #3574

Merged
merged 3 commits into from Jun 17, 2022
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jun 16, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #3574 (33b0c1d) into main (0b67e35) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3574   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        335     335           
  Lines      33253   33253           
=====================================
  Hits       33124   33124           
  Misses       129     129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b67e35...33b0c1d. Read the comment docs.

@rwedge rwedge marked this pull request as ready for review June 17, 2022 00:01
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

@rwedge rwedge merged commit e9b93af into main Jun 17, 2022
@rwedge rwedge deleted the unpin-nlp-primitives-constraint branch June 17, 2022 14:44
MichaelFu512 pushed a commit that referenced this pull request Jun 17, 2022
* Unpin nlp_primitives but disallow v2.60

* Update release_notes.rst

* more constraint / version updates
This was referenced Jun 23, 2022
chukarsten pushed a commit that referenced this pull request Jul 8, 2022
* Tried to implement batch/pipeline timing

* Unpin nlp_primitives but disallow v2.6.0 (#3574)

* Unpin nlp_primitives but disallow v2.60

* Update release_notes.rst

* more constraint / version updates

* 2734 Component Graph Instantiation Error (#3569)

* Throws error on describe if uninstantiated

* Added test for Exception

* Fixed linting and added to release_notes

* Made changes that Becca and Jeremy suggested

* Changed print to log, added function to logger

* Linting is correct

* Added test into test_logger.py

* Added tests for batch time results

* Updated release note

* Tried to fix merge conflict

* Added Jeremy's and Karsten's suggestions

* Simplified tests and added new error check

* Made it so that the dictionary always returns

* Added comments and made code clearer

* Fixed tests for search

* Fixed release_notes

* Fixed release notes

* Update automl_search.py

* Updated docstring

Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants