-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All tests don't skip python 3.9 #3602
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3602 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 335 335
Lines 33522 33503 -19
=======================================
- Hits 33393 33382 -11
+ Misses 129 121 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this, it's encouraging that no tests needed to be updated! I'm wondering if we should add prophet to the dev requirements - although at the moment I don't think it's necessary.
It looks like there are a few other files that have references to skipping with python 3.9:
evalml/tests/conftest.py
evalml/tests/component_tests/test_utils.py
Once those are updated as well, this should be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Michael! Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Description
Removed
pytest.mark.skip_if_39
from all tests as testing them in python 3.9, none of them failed.Did
conda create -n evalml_py_39 python=3.9
then didmake installdeps-dev
.After that, did a search using ctrl-f and looked for
pytest.mark.skip_if_39
from all files, removed them from the files that had them and ran each tests. None of the tests that previous were skipped failed.Only issue was two of the tests complained about not having prophet and cmdstanpy installed, but those were easily rectified by doing
pip install prophet
andpip install cmdstanpy
.Closes #3600
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.