Skip to content

Improve Woodwork Schema Transferrence#3604

Merged
eccabay merged 9 commits into
mainfrom
4315_ww_schema
Jul 11, 2022
Merged

Improve Woodwork Schema Transferrence#3604
eccabay merged 9 commits into
mainfrom
4315_ww_schema

Conversation

@eccabay
Copy link
Copy Markdown
Contributor

@eccabay eccabay commented Jul 7, 2022

This work ensures all our components pass the maximum amount of logical type knowledge to woodwork when calling ww.init within transformers' transform functions, with the goal of speeding up overall predict time (particularly for partial dependence)

Performance tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2022

Codecov Report

Merging #3604 (346dfcc) into main (92c71da) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3604     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        335     335             
  Lines      33512   33522     +10     
=======================================
+ Hits       33383   33393     +10     
  Misses       129     129             
Impacted Files Coverage Δ
...nents/transformers/imputers/time_series_imputer.py 100.0% <100.0%> (ø)
...ransformers/preprocessing/drop_rows_transformer.py 100.0% <100.0%> (ø)
...ents/transformers/preprocessing/log_transformer.py 100.0% <100.0%> (ø)
...transformers/preprocessing/polynomial_detrender.py 97.8% <100.0%> (+0.1%) ⬆️
...s/components/transformers/samplers/base_sampler.py 89.8% <100.0%> (+0.5%) ⬆️
...s/components/transformers/samplers/undersampler.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c71da...346dfcc. Read the comment docs.

@eccabay eccabay marked this pull request as ready for review July 7, 2022 20:32
Copy link
Copy Markdown
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig it! Thanks for doing this investigation and getting the changes out!!

elif self._impute_target == "interpolate":
y_imputed = y.interpolate()
y_imputed.bfill(inplace=True)
if y is not None and len(y) > 0:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to get at with the len(y) > 0 condition?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a test case where the passed in y was an empty Series instead of being None. Alternative would have been to change the test, I figured this was more robust but happy to swap.

Copy link
Copy Markdown
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eccabay eccabay enabled auto-merge (squash) July 11, 2022 17:13
@eccabay eccabay merged commit 931cd04 into main Jul 11, 2022
@eccabay eccabay deleted the 4315_ww_schema branch July 11, 2022 17:39
@chukarsten chukarsten mentioned this pull request Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants