Improve Woodwork Schema Transferrence#3604
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3604 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 335 335
Lines 33512 33522 +10
=======================================
+ Hits 33383 33393 +10
Misses 129 129
Continue to review full report at Codecov.
|
chukarsten
left a comment
There was a problem hiding this comment.
Dig it! Thanks for doing this investigation and getting the changes out!!
| elif self._impute_target == "interpolate": | ||
| y_imputed = y.interpolate() | ||
| y_imputed.bfill(inplace=True) | ||
| if y is not None and len(y) > 0: |
There was a problem hiding this comment.
What are you trying to get at with the len(y) > 0 condition?
There was a problem hiding this comment.
There was a test case where the passed in y was an empty Series instead of being None. Alternative would have been to change the test, I figured this was more robust but happy to swap.
This work ensures all our components pass the maximum amount of logical type knowledge to woodwork when calling
ww.initwithin transformers'transformfunctions, with the goal of speeding up overall predict time (particularly for partial dependence)Performance tests