OSSEVALML-80 Python 3.10 audit #3609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #3609 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 335 335
Lines 33840 33845 +5
=======================================
+ Hits 33712 33715 +3
- Misses 128 130 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jeremyliweishih
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
@cp2boston thank you for putting this up and investigating 3.10! A couple things:
- do you believe EvalML fully supports 3.10 at this point? If so we can also update the install page to reflect that! To do so you just need to update
docs/source/install.md - coverage tests will not pass for
in_container_arm64as it is not being run as part of our CI. @chukarsten will need to merge this PR in for you.
Lmk what you think!
chukarsten
approved these changes
Jul 15, 2022
| The env var is set in the Dockerfile.arm for the purposes of local | ||
| testing in a container on a mac M1, otherwise it's a noop. | ||
| """ | ||
| if os.getenv("DOCKER_ARM", None): |
There was a problem hiding this comment.
Do we want to # pragma: no cover this?
|
@cp2boston or @chukarsten Can we fix the lint error and release notes conflict here? |
- Dockerfile.arm reference for M1
chukarsten
force-pushed
the
OSSEVALML-80_3-10-support
branch
from
260d0cb to
cac97b6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This ticket provides minor updates to allow successful testing under python 3.10. Specifically:
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.