Implemented lower threshold and window size#3627
Merged
Conversation
…g with updated unit tests
|
|
Codecov Report
@@ Coverage Diff @@
## main #3627 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 335 335
Lines 33508 33529 +21
=======================================
+ Hits 33386 33407 +21
Misses 122 122
Continue to review full report at Codecov.
|
simha104
changed the title
Contributor
ParthivNaresh
left a comment
ParthivNaresh
left a comment
There was a problem hiding this comment.
Looks great! Just a few comments on clean ups
evalml/tests/data_checks_tests/test_datetime_format_data_check.py
Outdated
Show resolved
Hide resolved
ParthivNaresh
approved these changes
Jul 26, 2022
evalml/tests/data_checks_tests/test_datetime_format_data_check.py
Outdated
Show resolved
Hide resolved
bchen1116
approved these changes
Jul 27, 2022
Contributor
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
LGTM! Left a nit for clarity but not blocking
|
|
||
| The column "dates" has a set of dates with hourly frequency appended to the end of a series of days, which is inconsistent | ||
| with the frequency of the previous 9 dates (1 day). | ||
| The column "dates" has a set of two dates with monthly frequency appended to the end of a set of two dates with hourly frequency that is also appended to the end |
Contributor
There was a problem hiding this comment.
nit, but it'd be clearer to say
"The column 'dates' has a set of two dates with daily frequency, two dates with hourly frequency, and two dates with monthly frequency" or something of that sort
…ning' of github.com:alteryx/evalml into TML-3639-ds-feedback-ts-bug-time-index-format-check-warning
simha104
deleted the
TML-3639-ds-feedback-ts-bug-time-index-format-check-warning
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implemented lower threshold and window size along with corresponding unit tests