Skip to content

Updated data check code for regression - #3630

Merged
simha104 merged 11 commits into
mainfrom
ui-selecting-an-invalid-target-and-running-data-checks-results-in-duplicate-errors
Jul 29, 2022
Merged

Updated data check code for regression#3630
simha104 merged 11 commits into
mainfrom
ui-selecting-an-invalid-target-and-running-data-checks-results-in-duplicate-errors

Conversation

@simha104

@simha104 simha104 commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Updated data check code for regression

This is to avoid duplicate errors produced by non numerical regression and unsupported data types

@codecov

codecov Bot commented Jul 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3630 (95c618c) into main (6831b98) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3630     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        335     335             
  Lines      33637   33638      +1     
=======================================
+ Hits       33514   33515      +1     
  Misses       123     123             
Impacted Files Coverage Δ
evalml/data_checks/invalid_target_data_check.py 100.0% <ø> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <ø> (ø)
...ata_checks_tests/test_invalid_target_data_check.py 100.0% <ø> (ø)
evalml/data_checks/data_check_message_code.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6831b98...95c618c. Read the comment docs.

@simha104
simha104 marked this pull request as ready for review July 27, 2022 22:25

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustment! I think we should still adjust the name, though.

Comment thread evalml/data_checks/data_check_message_code.py Outdated

@bchen1116 bchen1116 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Karsten here, but looks good otherwise.

simha104 added 3 commits July 28, 2022 09:35
…results-in-duplicate-errors' of github.com:alteryx/evalml into ui-selecting-an-invalid-target-and-running-data-checks-results-in-duplicate-errors
@simha104
simha104 requested a review from chukarsten July 28, 2022 17:10
@simha104
simha104 enabled auto-merge (squash) July 28, 2022 21:02

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@simha104
simha104 merged commit e83e7db into main Jul 29, 2022
@simha104
simha104 deleted the ui-selecting-an-invalid-target-and-running-data-checks-results-in-duplicate-errors branch July 29, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants