Skip to content

Add Fit_transform to pipeline_base and component_graph - #3640

Merged
chukarsten merged 8 commits into
mainfrom
fit_transform_OSSEVALML-122
Aug 12, 2022
Merged

chukarsten merged 8 commits into
mainfrom
fit_transform_OSSEVALML-122

Conversation

@deanpatel2

Copy link
Copy Markdown
Contributor

Pull Request Description

Fixes #2665


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@CLAassistant

CLAassistant commented Aug 4, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Aug 4, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #3640 (bac68ec) into main (714efac) will decrease coverage by 1.7%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3640     +/-   ##
=======================================
- Coverage   99.6%   98.0%   -1.6%     
=======================================
  Files        335     335             
  Lines      33838   33879     +41     
=======================================
- Hits       33702   33187    -515     
- Misses       136     692    +556     
Impacted Files Coverage Δ
evalml/pipelines/component_graph.py 99.8% <100.0%> (+0.1%) ⬆️
evalml/pipelines/pipeline_base.py 98.5% <100.0%> (+0.1%) ⬆️
...valml/tests/pipeline_tests/test_component_graph.py 99.9% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <100.0%> (+0.1%) ⬆️
...ests/automl_tests/parallel_tests/test_cf_engine.py 0.0% <0.0%> (-100.0%) ⬇️
...ts/automl_tests/parallel_tests/test_dask_engine.py 0.0% <0.0%> (-100.0%) ⬇️
...ts/automl_tests/parallel_tests/test_automl_dask.py 27.3% <0.0%> (-64.3%) ⬇️
evalml/automl/engine/dask_engine.py 47.6% <0.0%> (-52.4%) ⬇️
evalml/automl/engine/cf_engine.py 54.3% <0.0%> (-44.0%) ⬇️
evalml/tests/automl_tests/dask_test_utils.py 66.7% <0.0%> (-33.3%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deanpatel2 deanpatel2 changed the title Add Fit_transform to pipeline_base and component_graph DRAFT: Add Fit_transform to pipeline_base and component_graph Aug 5, 2022
@deanpatel2
deanpatel2 force-pushed the fit_transform_OSSEVALML-122 branch from 2ca5df1 to 2dd61e6 Compare August 5, 2022 17:07
@deanpatel2
deanpatel2 force-pushed the fit_transform_OSSEVALML-122 branch from 2dd61e6 to 6f18bba Compare August 8, 2022 19:06
@deanpatel2
deanpatel2 marked this pull request as ready for review August 8, 2022 20:54

@christopherbunn christopherbunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for doing this!

@deanpatel2 deanpatel2 changed the title DRAFT: Add Fit_transform to pipeline_base and component_graph Add Fit_transform to pipeline_base and component_graph Aug 8, 2022

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I would just like an answer to Chris' question about the multiple calls being required.

@deanpatel2

Copy link
Copy Markdown
Contributor Author

Note: Found out the LabelEncoder class overrides its fit_transform method with its own self.fit().transform(). Thus, when its mock is called, it actually triggers 2 calls to its transform() unlike the OHE and Imputer

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great work @deanpatel2

@chukarsten
chukarsten merged commit 5ec5e6a into main Aug 12, 2022
@chukarsten
chukarsten deleted the fit_transform_OSSEVALML-122 branch August 12, 2022 17:35
@chukarsten chukarsten mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fit_transform() to pipelines and component graphs

5 participants