Repository navigation
Add Fit_transform to pipeline_base and component_graph - #3640
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3640 +/- ##
=======================================
- Coverage 99.6% 98.0% -1.6%
=======================================
Files 335 335
Lines 33838 33879 +41
=======================================
- Hits 33702 33187 -515
- Misses 136 692 +556
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
deanpatel2
force-pushed
the
fit_transform_OSSEVALML-122
branch
from
August 5, 2022 17:07
2ca5df1 to
2dd61e6
Compare
deanpatel2
force-pushed
the
fit_transform_OSSEVALML-122
branch
from
August 8, 2022 19:06
2dd61e6 to
6f18bba
Compare
deanpatel2
marked this pull request as ready for review
August 8, 2022 20:54
christopherbunn
approved these changes
Aug 8, 2022
christopherbunn
left a comment
Contributor
There was a problem hiding this comment.
Excellent, thanks for doing this!
christopherbunn
requested review from
chukarsten,
eccabay,
fjlanasa and
jeremyliweishih
August 8, 2022 21:28
chukarsten
suggested changes
Aug 10, 2022
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Think I would just like an answer to Chris' question about the multiple calls being required.
Contributor
Author
|
Note: Found out the LabelEncoder class overrides its |
jeremyliweishih
approved these changes
Aug 12, 2022
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! great work @deanpatel2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2665
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.