Skip to content

Conditionally include the imputer in pipelines#3657

Merged
chukarsten merged 13 commits intomainfrom
3603_include_imputer
Aug 15, 2022
Merged

Conditionally include the imputer in pipelines#3657
chukarsten merged 13 commits intomainfrom
3603_include_imputer

Conversation

@eccabay
Copy link
Copy Markdown
Contributor

@eccabay eccabay commented Aug 11, 2022

Closes #3603

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3657 (2dc96e0) into main (8a4d0ba) will increase coverage by 16.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #3657      +/-   ##
========================================
+ Coverage   83.5%   99.7%   +16.3%     
========================================
  Files        335     335              
  Lines      33845   33848       +3     
========================================
+ Hits       28231   33718    +5487     
+ Misses      5614     130    -5484     
Impacted Files Coverage Δ
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <ø> (+100.0%) ⬆️
evalml/pipelines/classification_pipeline.py 100.0% <100.0%> (ø)
evalml/pipelines/utils.py 99.5% <100.0%> (+1.4%) ⬆️
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+99.5%) ⬆️
...ts/automl_tests/test_automl_iterative_algorithm.py 100.0% <100.0%> (+100.0%) ⬆️
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.8% <100.0%> (ø)
evalml/automl/engine/engine_base.py 96.7% <0.0%> (+2.1%) ⬆️
evalml/tests/conftest.py 97.9% <0.0%> (+4.5%) ⬆️
.../preprocessing/data_splitters/time_series_split.py 96.7% <0.0%> (+13.4%) ⬆️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay eccabay marked this pull request as ready for review August 12, 2022 19:09
Copy link
Copy Markdown
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great work!

Copy link
Copy Markdown
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see a performance improvement for a change! But the pessimist in me filed #3668 to investigate whether this is reverting a previous regression.

@chukarsten chukarsten merged commit ceebe08 into main Aug 15, 2022
@chukarsten chukarsten deleted the 3603_include_imputer branch August 15, 2022 20:52
@chukarsten chukarsten mentioned this pull request Aug 16, 2022
chukarsten added a commit that referenced this pull request Aug 19, 2022
chukarsten added a commit that referenced this pull request Aug 19, 2022
* Revert "Conditionally include the imputer in pipelines (#3657)"

This reverts commit ceebe08.

* Release.

* Fixed release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conditionally include the imputer in pipelines

3 participants