Conditionally include the imputer in pipelines#3657
Merged
chukarsten merged 13 commits intomainfrom Aug 15, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3657 +/- ##
========================================
+ Coverage 83.5% 99.7% +16.3%
========================================
Files 335 335
Lines 33845 33848 +3
========================================
+ Hits 28231 33718 +5487
+ Misses 5614 130 -5484
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jeremyliweishih
approved these changes
Aug 15, 2022
Collaborator
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM - great work!
chukarsten
approved these changes
Aug 15, 2022
Contributor
chukarsten
left a comment
There was a problem hiding this comment.
Great to see a performance improvement for a change! But the pessimist in me filed #3668 to investigate whether this is reverting a previous regression.
Merged
chukarsten
added a commit
that referenced
this pull request
Aug 19, 2022
This reverts commit ceebe08.
chukarsten
added a commit
that referenced
this pull request
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3603