Unpinned sktime to allow for version 0.13.2 - #3685
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3685 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 337 337
Lines 34077 34078 +1
=======================================
+ Hits 33946 33947 +1
Misses 131 131
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
christopherbunn
force-pushed
the
368-uncap-sktime
branch
from
August 30, 2022 19:59
5c0b00a to
7e70a89
Compare
christopherbunn
changed the title
christopherbunn
force-pushed
the
368-uncap-sktime
branch
from
September 1, 2022 16:19
780509c to
22e0dda
Compare
christopherbunn
marked this pull request as ready for review
September 1, 2022 16:19
christopherbunn
requested review from
chukarsten,
eccabay,
fjlanasa and
jeremyliweishih
September 1, 2022 16:20
jeremyliweishih
approved these changes
Sep 1, 2022
| assert isinstance(predict_output, pd.Series) | ||
| assert len(predict_output) == len(y) | ||
| assert predict_output.name is None | ||
| if component.name != "Exponential Smoothing Regressor": |
Collaborator
There was a problem hiding this comment.
let's just remove the name to make it consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3660