Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinned sktime to allow for version 0.13.2 #3685

Merged
merged 12 commits into from
Sep 1, 2022
Merged

Conversation

christopherbunn
Copy link
Contributor

Resolves #3660

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #3685 (5fc0139) into main (368106d) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3685     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        337     337             
  Lines      34077   34078      +1     
=======================================
+ Hits       33946   33947      +1     
  Misses       131     131             
Impacted Files Coverage Δ
...tors/regressors/exponential_smoothing_regressor.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christopherbunn christopherbunn changed the title Uncap sktime version Unpinned sktime to allow for version 0.13.2 Aug 30, 2022
@@ -215,7 +215,8 @@ def test_estimator_predict_output_type(X_y_binary, helper_functions):
predict_output = component.predict(X)
assert isinstance(predict_output, pd.Series)
assert len(predict_output) == len(y)
assert predict_output.name is None
if component.name != "Exponential Smoothing Regressor":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just remove the name to make it consistent

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@christopherbunn christopherbunn enabled auto-merge (squash) September 1, 2022 17:51
@christopherbunn christopherbunn merged commit b1bfafd into main Sep 1, 2022
@christopherbunn christopherbunn deleted the 368-uncap-sktime branch September 1, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin sktime and identify time series modeling slowdown
3 participants