Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action to run looking glass perf tests on merge to main #3690

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

fjlanasa
Copy link
Contributor

@fjlanasa fjlanasa commented Sep 1, 2022

Pull Request Description

(replace this text with your description)

This action will:

  • run perf tests for the current and previous commit on main using both iterative and default algos
  • generate reports and upload to s3
  • send a message in slack with links to the reports

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #3690 (1353a5f) into main (d61bbb1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3690   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        339     339           
  Lines      34465   34465           
=====================================
  Hits       34338   34338           
  Misses       127     127           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me! We might need to update the ticket and keep it open or add a new ticket to integrate this further with the "run lg on server" story. Our ultimate goal will be that this story will not just perf test main, but also generate the report to diff against the last commit. As it is right now (which is great), we're just perf testing main and will need to manually diff against the previous commit.

  • Filed this ticket to update our slackbot.
  • Filed this ticket to generate a report against the previous commit and post it in the slackbot.

@chukarsten chukarsten enabled auto-merge (squash) September 6, 2022 18:19
@fjlanasa fjlanasa closed this Sep 6, 2022
@fjlanasa fjlanasa reopened this Sep 6, 2022
@fjlanasa fjlanasa force-pushed the lg-main branch 4 times, most recently from d8f765a to a18486f Compare September 7, 2022 01:03
@fjlanasa fjlanasa changed the title add github action to run looking glass perf tests on merge to main Draft: add github action to run looking glass perf tests on merge to main Sep 13, 2022
@fjlanasa fjlanasa changed the title Draft: add github action to run looking glass perf tests on merge to main add github action to run looking glass perf tests on merge to main Sep 14, 2022
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few Slack message suggestions and next step suggestions but otherwise looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants