-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github action to run looking glass perf tests on merge to main #3690
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3690 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 339 339
Lines 34465 34465
=====================================
Hits 34338 34338
Misses 127 127 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e65c177
to
09529ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid to me! We might need to update the ticket and keep it open or add a new ticket to integrate this further with the "run lg on server" story. Our ultimate goal will be that this story will not just perf test main, but also generate the report to diff against the last commit. As it is right now (which is great), we're just perf testing main and will need to manually diff against the previous commit.
d8f765a
to
a18486f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few Slack message suggestions and next step suggestions but otherwise looks good to merge.
Pull Request Description
(replace this text with your description)
This action will:
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.