Handle time index with exclude featurizers#3691
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3691 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 339 339
Lines 34251 34307 +56
=======================================
+ Hits 34122 34179 +57
+ Misses 129 128 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| automl.search() | ||
|
|
||
| rankings = automl.rankings | ||
| for score in rankings["validation_score"].values: | ||
| assert pd.notnull(score) |
There was a problem hiding this comment.
Can you add a test, either here or as an independent test, that should_drop_time_index is getting set correctly for all pipelines?
There was a problem hiding this comment.
@eccabay I added the explicit check for the value of should_drop_time_index to this test. Let me know if there is a better way to do this as I'm not super familiar with the best way to iterate overall the pipelines generated by .search().
There was a problem hiding this comment.
Works for me! I don't think we have a super clean way to iterate through all the pipelines right now, so imo whatever works goes.
Various updates to handle dropping time index properly when
DateTimeFeaturizerandTimeSeriesFeaturizerare excluded for time series problems. These updates retain time index column for time series native estimators, but drop it otherwise.