Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detrender Base Class & PolynomialDetrender Modifications Rebased #3720

Merged
merged 73 commits into from
Sep 20, 2022

Conversation

chukarsten
Copy link
Contributor

@chukarsten chukarsten commented Sep 19, 2022

Please see #3599 for review. Due to git difficulties, had to open a new branch.

…and the get_trend_df function to PolynomialDetrender.
… time series data to the PolynomialDecomposer.
…eIndex as it always should. Increased coverage.
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #3720 (ec32ac7) into main (b60eab3) will increase coverage by 0.1%.
The diff coverage is 99.8%.

@@           Coverage Diff           @@
##            main   #3720     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        339     340      +1     
  Lines      34386   34667    +281     
=======================================
+ Hits       34254   34535    +281     
  Misses       132     132             
Impacted Files Coverage Δ
evalml/pipelines/component_graph.py 99.8% <ø> (ø)
evalml/pipelines/components/__init__.py 100.0% <ø> (ø)
...alml/pipelines/components/transformers/__init__.py 100.0% <ø> (ø)
evalml/pipelines/pipeline_base.py 98.5% <ø> (ø)
evalml/tests/component_tests/test_utils.py 99.1% <ø> (ø)
...ransformers/preprocessing/polynomial_decomposer.py 99.3% <99.3%> (ø)
.../components/transformers/preprocessing/__init__.py 100.0% <100.0%> (ø)
...omponents/transformers/preprocessing/decomposer.py 100.0% <100.0%> (ø)
...l/pipelines/components/transformers/transformer.py 100.0% <100.0%> (ø)
...sts/decomposer_tests/test_polynomial_decomposer.py 100.0% <100.0%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chukarsten chukarsten changed the title Detrender rebased Detrender Base Class & PolynomialDetrender Modifications Rebased Sep 20, 2022
@chukarsten chukarsten merged commit ec3ef27 into main Sep 20, 2022
@chukarsten chukarsten deleted the detrender_rebased branch September 20, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant