Ignore sorting of time index via woodwork for DataChecks#3723
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3723 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 338 338
Lines 34659 34672 +13
=======================================
+ Hits 34527 34540 +13
Misses 132 132
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Might be good to add a test to ensure that this is upheld as expected |
Cmancuso
reviewed
Sep 21, 2022
Cmancuso
left a comment
Cmancuso
left a comment
There was a problem hiding this comment.
Also looks good to me, but agree with @bchen1116 on testing. Could be an integration test or tempo test as well if that's easier.
ParthivNaresh
requested review from
Cmancuso,
eccabay,
jeff-hernandez and
jeremyliweishih
bchen1116
approved these changes
Sep 27, 2022
Contributor
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Thanks for adding the test!
| "1/10/21", | ||
| "1/4/21", | ||
| ] | ||
| y = pd.Series([i for i in range(9)]) |
Contributor
There was a problem hiding this comment.
could shorthand this to y = pd.Series(range(9))
Cmancuso
approved these changes
Sep 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.