Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix holdout warning message showing when using default parameters #3727

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

christopherbunn
Copy link
Contributor

Currently, we show our warning that AutoML search will not be evaluated with a holdout set even when holdout_set_size=0 (which is the default). This PR fixes this and a typo in the error message.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #3727 (ae7abee) into main (4c0f57a) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3727     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        340     340             
  Lines      34667   34671      +4     
=======================================
+ Hits       34535   34539      +4     
  Misses       132     132             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.5% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christopherbunn christopherbunn marked this pull request as ready for review September 21, 2022 19:41
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chukarsten chukarsten merged commit 58ce172 into main Sep 23, 2022
@chukarsten chukarsten deleted the fix_holdout_message_when_0 branch September 23, 2022 19:29
@chukarsten chukarsten mentioned this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants