Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IDColumnsDataCheck to work with IntegerNullable logical type #3740

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

IDColumnsDataCheck

Closes #3738

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #3740 (10c6d9c) into main (03a6782) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3740     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        339     339             
  Lines      34810   34819      +9     
=======================================
+ Hits       34679   34688      +9     
  Misses       131     131             
Impacted Files Coverage Δ
evalml/data_checks/id_columns_data_check.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 98.2% <100.0%> (+0.1%) ⬆️
...ts/data_checks_tests/test_id_columns_data_check.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) October 4, 2022 13:08
@thehomebrewnerd thehomebrewnerd merged commit 6dc8b76 into main Oct 4, 2022
@thehomebrewnerd thehomebrewnerd deleted the issue-3738-idcolcheck-integernullable branch October 4, 2022 13:35
@ivanayx ivanayx mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDColumnsDataCheck does not work properly on IntegerNullable columns
3 participants