Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nlp imports #3778

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Fix nlp imports #3778

merged 8 commits into from
Oct 25, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Oct 25, 2022

This PR makes a few updates for compatibility with the latest versions of Featuretools and nlp-primitives:

  • Change nlp primitive import statements
  • Remove upper bound version restriction on Featuretools and nlp-primitives
  • Bump nlp-primitives lowest allowed version to allow all primitives to be imported using from featuretools.primitives import ... instead of from nlp_primitives import ...

@thehomebrewnerd thehomebrewnerd marked this pull request as draft October 25, 2022 13:13
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #3778 (2a9b352) into main (fa71b7b) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3778     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        343     343             
  Lines      35681   35680      -1     
=======================================
- Hits       35545   35544      -1     
  Misses       136     136             
Impacted Files Coverage Δ
...rmers/preprocessing/natural_language_featurizer.py 98.9% <100.0%> (-<0.1%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thehomebrewnerd thehomebrewnerd marked this pull request as ready for review October 25, 2022 14:15
@thehomebrewnerd thehomebrewnerd changed the title [DRAFT] Fix nlp imports Fix nlp imports Oct 25, 2022
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsheni gsheni enabled auto-merge (squash) October 25, 2022 15:07
@chukarsten chukarsten disabled auto-merge October 25, 2022 15:07
@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) October 25, 2022 15:08
@thehomebrewnerd thehomebrewnerd merged commit ed2a248 into main Oct 25, 2022
@thehomebrewnerd thehomebrewnerd deleted the fix-nlp-imports branch October 25, 2022 15:57
@chukarsten chukarsten mentioned this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants