Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_time_index bug #3792

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Fix get_time_index bug #3792

merged 6 commits into from
Oct 28, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Oct 27, 2022

We were doing some unnecessary conversion of a DatetimeIndex into a Series and then back, which threw some errors with certain datetime data. This fixes both those issues!

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #3792 (d6213df) into main (b5eb7b0) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3792     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        343     343             
  Lines      35797   35813     +16     
=======================================
+ Hits       35660   35676     +16     
  Misses       137     137             
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_gen_utils.py 99.5% <100.0%> (+0.1%) ⬆️
evalml/utils/gen_utils.py 99.3% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay eccabay marked this pull request as ready for review October 27, 2022 20:12
@eccabay eccabay enabled auto-merge (squash) October 28, 2022 20:48
@eccabay eccabay merged commit 6788c06 into main Oct 28, 2022
@eccabay eccabay deleted the datetime_idx_freq_fix branch October 28, 2022 21:22
@chukarsten chukarsten mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants