Pin dask below 2022.10.1 - #3797
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3797 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 343 343
Lines 35813 35813
=====================================
Hits 35676 35676
Misses 137 137 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eccabay
marked this pull request as ready for review
October 31, 2022 13:40
eccabay
requested review from
christopherbunn,
chukarsten and
jeremyliweishih
and removed request for
jeremyliweishih
October 31, 2022 13:40
jeremyliweishih
approved these changes
Oct 31, 2022
Contributor
|
This PR on dask should fix the tests but is not yet released. |
Contributor
Author
|
Thanks for pointing that out @bchen1116! I'll file an issue to unpin dask once that PR is in, since we don't need dependency updates blocking us until then. |
chukarsten
approved these changes
Oct 31, 2022
chukarsten
added a commit
that referenced
this pull request
Oct 31, 2022
This reverts commit d1f64aa.
This was referenced Oct 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent dask version seems to break a bunch of our unit tests. Pinning the version until we figure out what's up.