Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade evalml to latest xgboost #3805

Merged
merged 8 commits into from
Nov 2, 2022
Merged

Upgrade evalml to latest xgboost #3805

merged 8 commits into from
Nov 2, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Nov 1, 2022

In their most recent release, xgboost deprecated their _use_label_encoder argument, which caused a number of our tests to fail. This removes the usage of that argument entirely.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #3805 (641634f) into main (5945a41) will increase coverage by 44.8%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #3805      +/-   ##
========================================
+ Coverage   54.9%   99.7%   +44.8%     
========================================
  Files        343     343              
  Lines      35813   35794      -19     
========================================
+ Hits       19660   35657   +15997     
+ Misses     16153     137   -16016     
Impacted Files Coverage Δ
...l/tests/component_tests/test_xgboost_classifier.py 100.0% <ø> (ø)
...nents/estimators/classifiers/xgboost_classifier.py 100.0% <100.0%> (+1.9%) ⬆️
...components/transformers/imputers/target_imputer.py 100.0% <0.0%> (+1.8%) ⬆️
evalml/automl/engine/engine_base.py 96.7% <0.0%> (+2.1%) ⬆️
...rs/preprocessing/transform_primitive_components.py 100.0% <0.0%> (+2.7%) ⬆️
...components/transformers/scalers/standard_scaler.py 100.0% <0.0%> (+2.8%) ⬆️
.../pipelines/binary_classification_pipeline_mixin.py 100.0% <0.0%> (+3.2%) ⬆️
evalml/pipelines/binary_classification_pipeline.py 100.0% <0.0%> (+4.2%) ⬆️
...l/pipelines/components/transformers/transformer.py 100.0% <0.0%> (+4.4%) ⬆️
...components/transformers/encoders/target_encoder.py 100.0% <0.0%> (+5.0%) ⬆️
... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay eccabay marked this pull request as ready for review November 1, 2022 13:20
@chukarsten chukarsten merged commit a9c02aa into main Nov 2, 2022
@chukarsten chukarsten deleted the xgboost_upgrade branch November 2, 2022 00:53
@chukarsten chukarsten mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants