-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum Pandas version to 1.5.0 #3808
Conversation
775a2e3
to
131303a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3808 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 344 344
Lines 36191 36191
=====================================
Hits 36054 36054
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dbc0118
to
3ef4b54
Compare
@@ -73,7 +73,7 @@ outputs: | |||
- lime >=0.2.0.1 | |||
- python >=3.8.* | |||
- imbalanced-learn >=0.9.1 | |||
- sktime <0.13.1,>=0.12.0 | |||
- sktime >=0.13.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conda is currently failing as it looks like the latest version of sktime that is available on conda is 0.12.1 when we need this version for pandas 1.5 support. If pandas 1.5 support isn't super high priority we might need to skip conda support for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sktime/sktime#2921 - related. Can you file an issue against sktime to release 0.13.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM pending conda release of sktime.
47d6283
to
0b80b27
Compare
0b80b27
to
9533f56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Resolves #3759