Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Pandas version to 1.5.0 #3808

Merged
merged 11 commits into from
Dec 5, 2022

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Nov 1, 2022

Resolves #3759

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #3808 (a95f7ef) into main (3007091) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #3808   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        344     344           
  Lines      36191   36191           
=====================================
  Hits       36054   36054           
  Misses       137     137           
Impacted Files Coverage Δ
...rmers/preprocessing/natural_language_featurizer.py 98.9% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -73,7 +73,7 @@ outputs:
- lime >=0.2.0.1
- python >=3.8.*
- imbalanced-learn >=0.9.1
- sktime <0.13.1,>=0.12.0
- sktime >=0.13.3
Copy link
Contributor Author

@christopherbunn christopherbunn Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conda is currently failing as it looks like the latest version of sktime that is available on conda is 0.12.1 when we need this version for pandas 1.5 support. If pandas 1.5 support isn't super high priority we might need to skip conda support for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sktime/sktime#2921 - related. Can you file an issue against sktime to release 0.13.3?

@christopherbunn christopherbunn changed the title Pandas 1.5 Update Update minimum Pandas version to 1.5.0 Nov 2, 2022
@christopherbunn christopherbunn marked this pull request as ready for review November 2, 2022 16:49
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM pending conda release of sktime.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@christopherbunn christopherbunn merged commit d8f9c68 into main Dec 5, 2022
@christopherbunn christopherbunn deleted the OSSEVALML_405_pandas_15_upgrade branch December 5, 2022 21:26
@christopherbunn christopherbunn mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Pandas 1.5
3 participants