Update minimum Pandas version to 1.5.0#3808
Merged
Merged
Conversation
christopherbunn
force-pushed
the
OSSEVALML_405_pandas_15_upgrade
branch
from
775a2e3 to
131303a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3808 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 344 344
Lines 36191 36191
=====================================
Hits 36054 36054
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
christopherbunn
force-pushed
the
OSSEVALML_405_pandas_15_upgrade
branch
from
dbc0118 to
3ef4b54
Compare
christopherbunn
commented
Nov 2, 2022
| - python >=3.8.* | ||
| - imbalanced-learn >=0.9.1 | ||
| - sktime <0.13.1,>=0.12.0 | ||
| - sktime >=0.13.3 |
Contributor
Author
There was a problem hiding this comment.
The conda is currently failing as it looks like the latest version of sktime that is available on conda is 0.12.1 when we need this version for pandas 1.5 support. If pandas 1.5 support isn't super high priority we might need to skip conda support for now.
Collaborator
There was a problem hiding this comment.
sktime/sktime#2921 - related. Can you file an issue against sktime to release 0.13.3?
christopherbunn
changed the title
christopherbunn
requested review from
chukarsten,
eccabay and
jeremyliweishih
jeremyliweishih
approved these changes
Nov 2, 2022
Collaborator
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
This LGTM pending conda release of sktime.
christopherbunn
force-pushed
the
OSSEVALML_405_pandas_15_upgrade
branch
from
47d6283 to
0b80b27
Compare
christopherbunn
force-pushed
the
OSSEVALML_405_pandas_15_upgrade
branch
from
0b80b27 to
9533f56
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3759